-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structural improvements to SpeziLLM #45
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 32.82% 31.50% -1.32%
==========================================
Files 56 66 +10
Lines 2322 2750 +428
==========================================
+ Hits 762 866 +104
- Misses 1560 1884 +324
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the PR and the improvements @philippzagar! I only had a few comments here and there that would be great if they can be addressed. The semaphore could be addressed in a separate PR as a follow up once the Bluetooth code is merged and elements might have moved over to Spezi Foundation.
Structural improvements to SpeziLLM
♻️ Current situation & Problem
As of now, when adjusting LLMonFHIR and SpeziFHIR, we noticed some structural limitations of the SpeziLLM library.
⚙️ Release Notes
📚 Documentation
Proper documentation is written for all components.
✅ Testing
Proper manual testing as well as UI tests
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: