Preliminary support for Ray in Task-Bench #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Sorry for taking so long to look at this. The implementation looks good. I think the outstanding items are:
- Build infrastructure: need to fill out
get_deps.sh,build_all.sh,test_all.shso that we can run this in CI (and on supercomputers). You can see Dask as an example. - Performance: optional for the first PR, but it would be nice to get to get (a) performance numbers, and (b) a review by the Ray team to make sure everything looks ok.
| os.path.join(root_dir, "core/core_c.h") | ||
| ]).decode("utf-8") | ||
| ffi = cffi.FFI() | ||
| ffi.cdef(core_header) | ||
| c = ffi.dlopen("libcore.so") |
There was a problem hiding this comment.
I don't think you're trying to modify the Dask implementation, and this seems to work in our CI. Do you need this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't make any claims about Ray's performance, but just sets up infrastructure within task-bench to perform further evaluations of Ray.