StripDataSource #62
Draft
StripDataSource #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottslaughter
force-pushed
the
strip-ds
branch
from
9122c5a to
19facae
Compare
|
If you want something that is not quite a drastic hammer (e.g., being more specific about what gets stripped instead of taking out essentially every human-readable string), then it will probably need to be implemented at the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates one possible way to strip proprietary information out of profiles. It provides an adapter for the
DataSourceinterface that takes anotherDataSourceand then filters all the resultingItemMetas to redact all the string contents of those profiles. At the moment it's a pretty heavy hammer so it just strips out everything.