Split app key from viewport title to stop spraying app.ron files everywhere
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ywhere. Egui uses the app key to determine the storage location for persisted configuration files. This does not work well when the app key is something like "~/Downloads/prof_0.gz - Legion Prof" (the case when profiling files you've just downloaded), which results in the app.ron files being persisted to some random subdirectory of ~/Downloads instead of "~/Library/Application Support/Legion Prof" or something similar (depending on the OS). So split the app key off from the viewport title so that the former can be short and predictable and not mess with the persistent config location so badly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Egui uses the app key to determine the storage location for persisted configuration files. This does not work well when the app key is something like
~/Downloads/prof_0.gz - Legion Prof(the case when profiling files you've just downloaded), which results in theapp.ronfiles being persisted to some random subdirectory of~/Downloadsinstead of~/Library/Application Support/Legion Profor something similar (depending on the OS).So split the app key off from the viewport title so that the former can be short and predictable and not mess with the persistent config location so badly.