Repository navigation
C11-250: close safety follow-ups from #469 - #561
Merged
Merged
Conversation
…-safety # Conflicts: # Sources/AppDelegate.swift
…endered-card test Adds a hosted-card pixel test (missing selection renders the same as Cancel selected and differs from Confirm selected) and a Return-routing test for an active confirm with a missing selection, plus a DEBUG-only seam to clear the published selection. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…te equality Whole-image byte equality differed in a few antialiased pixels between runs. The test now checks the missing-selection render is closer to the Cancel-selected reference than to the Confirm-selected one. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
BenevolentFutures
marked this pull request as ready for review
October 2, 2026 23:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups 2, 5 and 6 from the #469 shutdown-snapshot review (C11-250).
unregisterMainWindowno longer drops the main-window close guard beforewindowWillClosereaches it. Guard cleanup stays in the delegate callback.window.closereturnsinvalid_state(v1close_windowreturns an explicit error) when an operator close sheet is attached, instead of a false OK. Unknown windows still returnnot_found..cancelfallback.Not in this PR: findings 1, 3, 4, 7, 8, 9. No new strings, persisted fields, or hot-path changes. App-termination callback untouched.
Tests: Atlas targeted tests pass (close-guard teardown ordering, attached-sheet socket close, card fallback). Runtime proof in an Atlas guest on the packaged tagged build: with the close sheet attached, v2 and v1 close are rejected, the window and sheet remain, Cancel keeps the window open, and a close with no sheet still works. Details in the C11-250 validation comment.
🤖 Generated with Claude Code