Repository navigation
Report tab-strip overflow and the count-cell anchor - #10
Merged
Merged
Conversation
The host can tell when a pane's strip is scrolling or folded, and can anchor a popover on that pane's count cell. Reports are edge-triggered. The anchor view is not retained, and a reader that is leaving the window does not clear a live replacement. Co-Authored-By: Grok 4.7 <noreply@x.ai>
A closed pane no longer keeps its overflow bit, count-cell anchor, or sheet flag. The collapsed header comment matches the anchor reader: that view's hitTest returns nil, so the bar's tap still fires. Co-Authored-By: Grok 4.7 <noreply@x.ai>
BenevolentFutures
force-pushed
the
c11-245-count-cell-anchor
branch
from
October 1, 2026 07:12
cc72cff to
ba5bb79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two host callbacks on
BonsplitController, plus the tab bar reporting into them:onTabStripOverflow: a pane's strip can scroll, or it has folded into the solid block. False while that pane's rail is open. Edge-triggered.onCountCellAnchor: the count cell'sNSView, so a host can anchor a popover under it. The same view is not reported twice, and the view is not retained. A reader whose view has left its window does not clear a different view that is still on screen.onTabSheetOpenChanged: the pane's tab sheet opened or closed.The count cell reports from the scrolling strip, the folded block, and the rail bar. The reader does not hit-test, so it does not take the cell's click. Nothing here runs on the typing path.
Why
c11's rail tip (C11-245) has to sit under the count cell and know when the strip overflows. Both facts live in the tab bar. The host keeps the tip copy, the trigger policy, and the defaults.
How validated
Not built locally (laptop build lock). CI on this PR is the compile check. c11's logic tests cover the trigger policy; they do not link this UI.
The c11 PR will pin this SHA until it is on
main. Please merge with a merge commit so that pin can move to the merge commit.