pants ci: add integration tests job #6273
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
cognifloyd
force-pushed
the
pants-itests
branch
10 times, most recently
from
6575608
to
7f869b9
Compare
pull-request-size
bot
added
size/XL
cognifloyd
force-pushed
the
pants-itests
branch
3 times, most recently
from
1d377cb
to
11b7e65
Compare
pull-request-size
bot
added
size/XXL
cognifloyd
force-pushed
the
pants-itests
branch
from
ca88923
to
b03451a
Compare
Only run them when ST2_CI==true to minimize requirements for local development. Also fix a typo in a comment.
These changes were already made for MongoDB and RabbitMQ rules. This removes a TODO comment and slightly refactors to follow the same convention.
pants `--tag=...` notes:
`--tags=abc,def` (a csv list):
is an OR condition (either `abc` tag, or `def` tag, or both).
`--tags=abc --tag=def` (multiple entries):
is an AND condition (Both `abc` tag AND `def` tag).
So, we use `--tag=integration --tag=-st2cluster` to select targets
that have the `integration` tag AND do NOT have the `st2cluster` tag.
pants `--tag=...` notes:
`--tags=abc,def` (a csv list):
is an OR condition (either `abc` tag, or `def` tag, or both).
`--tags=abc --tag=def` (multiple entries):
is an AND condition (Both `abc` tag AND `def` tag).
So, we use `--tag=integration --tag=st2cluster` to select targets
that have the `integration tag AND the `st2cluster` tag.
(The other integration test job excludes the st2cluster tagged targets).
cognifloyd
force-pushed
the
pants-itests
branch
2 times, most recently
from
6a4511d
to
ca2d42f
Compare
This was referenced Nov 12, 2024
|
Planned sequence of PRs: flowchart LR
A("✅ #6275: BUILD metadata") ---> D("✅ 6279: pants-plugins/uses_services st2cluster")
D --> H("#6273: Add integration tests job")
B("✅ #6276: Refactor CI scripts") ---> G("?: Add redis namespace + ST2_* ST2TESTS_* vars in launchdev.sh")
G --> H
C("✅ #6277: env var support") --> E("⏳ 6278: pants-plugins/uses_services refactor + mongo")
E --> F("?: Add messaging.prefix option") & G
F --> H
|
winem
approved these changes
Nov 16, 2024
This was referenced Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running integration tests requires making the tests parallel safe with RabbitMQ and Redis.