Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added no-store header to st2 nginx configuration #6264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fdrab
Copy link
Contributor

@fdrab fdrab commented Oct 19, 2024

Added the no-store cache control header in order to prevent webui from serving cached and not up-to-date versions of opened workflows.

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Oct 19, 2024
@fdrab
Copy link
Contributor Author

fdrab commented Oct 21, 2024

would there be a performance impact if the no-store, no-cache was put at the beginning on the conf? It was reported to me that the issue is still there if it's at the end in /

I need to double check

@fdrab
Copy link
Contributor Author

fdrab commented Oct 23, 2024

I have no idea how to set this for / location only. I've now tried everything. Is it an issue if this was a global header?

Copy link
Contributor

@guzzijones guzzijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have also seen this internally with our gui devs. I am fine with no store cache on nginx.

@fdrab
Copy link
Contributor Author

fdrab commented Oct 26, 2024

Can you please validate with them where do they put the headers? I've put them into the / location, but it has been reported to me by my devs that this doesn't seem to work and they're still facing issues because they're loading stale flows from the cache. So, before this is merged, it would be nice if we knew whether this actually works.

Copy link
Contributor

@guzzijones guzzijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping this was the fix. I will have to dig a little deeper on my end.

@guzzijones
Copy link
Contributor

Have your users disabled their cache locally?

@fdrab
Copy link
Contributor Author

fdrab commented Oct 31, 2024

no, but I haven't asked them to (and all the guides on how to do this on the web are sort of... hacky). I've had a setup on a virtual machine, where the install was local and this was a set and forget kind of thing. But now I'm moving to EKS and while I can just set it in the st2web containers and reload nginx, I don't like the thought of doing this after every update to the pipeline that restarts the pods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants