-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.8 to 3.11 mongo 7.0 #6236
base: master
Are you sure you want to change the base?
Conversation
… requirements and regenerate locking
… when binary not found.
…2. Use 'parser.read_file()' instead.
4da44b5
to
5ad1538
Compare
@nzlosh @cognifloyd this is now passing testing. pytest doesn't offer a way to split tests so I removed chunk 1 chunk 2, etc. |
chunk1 and chunk2 were running the exact same tests from what I can tell. I don't see any usage of NODE_TOTAL or NODE_INDEX in our workflow code or testing code. |
The switch to pytest makes those vars obsolete. They were used by |
I'm going to slowly review this PR. I plan to look for isolated pieces of this PR that could go in separate PRs to make each bit of functionality easier to review and check for completeness. I understand that breaking up a large PR can be painful, so I'll try to minimize that pain as much as I can. |
it is mostly just pytest changes.
…On Thu, Sep 12, 2024 at 22:38 Jacob Floyd ***@***.***> wrote:
I'm going to slowly review this PR. I plan to look for isolated pieces of
this PR that could go in separate PRs to make each bit of functionality
easier to review and check for completeness. I understand that breaking up
a large PR can be painful, so I'll try to minimize that pain as much as I
can.
|
python 3.12 works. mongodb 7.0 works.
I also fixed some unit tests.
This merges in @FileMagic and @nzlosh work on mongo 7.0.