-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out the zstandard change with history. #6166
Open
rebrowning
wants to merge
70
commits into
StackStorm:master
Choose a base branch
from
rebrowning:zstandard_split
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… embedded liveaction doc in executions
Co-authored-by: Jacob Floyd <[email protected]>
… found in api response
remove comment Co-authored-by: Jacob Floyd <[email protected]>
pull-request-size
bot
added
the
size/XXL
PR that changes 1000+ lines. You should absolutely split your PR into several.
label
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like as part of the rebase to update the branch it added my name as well, but the complete history should be there now.
splitting out the zstandard work done by @guzzijones in #5995
If we would rather just have the original PR go through, lmk and I can close this. But I saw a comment on his PR that it'd be nice to split the two out.
All credit for work on this goes to @guzzijones , I'm splitting it out with the hope of moving it through so we can mitigate the document size errors.