-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added get-dependencies option to install_pack.py #5994
Open
jk464
wants to merge
1
commit into
StackStorm:master
Choose a base branch
from
jk464:feature/pack_download
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
PR that changes 30-99 lines. Good size to review.
label
Jun 21, 2023
needs a changelog entry |
jk464
force-pushed
the
feature/pack_download
branch
from
August 15, 2023 14:31
3a547d6
to
edcaec2
Compare
@guzzijones I've added a Changelog entry now |
guzzijones
requested changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple small adjustments. Thanks for your contribution.
jk464
force-pushed
the
feature/pack_download
branch
from
August 23, 2023 11:13
271f8d3
to
c52e8f4
Compare
pull-request-size
bot
added
size/L
PR that changes 100-499 lines. Requires some effort to review.
and removed
size/M
PR that changes 30-99 lines. Good size to review.
labels
Aug 23, 2023
guzzijones
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me now
jk464
force-pushed
the
feature/pack_download
branch
from
May 25, 2024 12:42
c52e8f4
to
2bee3c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances
install_pack.py
so that you can pass an optional flag to it (--get-dependencies
) that will for a given pack when it is installed will also install any other packs the parent pack depdends on it.Useful when using https://github.com/StackStorm/st2packs-dockerfiles/ to build a
st2packs
image, the user only has to provide the list of packs they want, without having to determine if they have any further packs as depdencies.