Pants: Misc pants-plugins/uses_services improvements
#5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
winem,
arm4b,
nzlosh,
rush-skills,
amanda11 and
a team
pull-request-size
bot
added
the
size/XS
cognifloyd
force-pushed
the
pants-plugins-misc
branch
from
b39cc33
to
6a4a3b8
Compare
nzlosh
approved these changes
Feb 14, 2023
cognifloyd
force-pushed
the
pants-plugins-misc
branch
from
6a4a3b8
to
677e7b6
Compare
rush-skills
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
2 quick fixes for issues I noticed with the pants-plugins:
pants-plugins/uses_servicesmongo tests where we expect the check to fail so that the tests go faster.pants-plugins/uses_servicesadded in Updatepants-plugins/uses_servicesto support checking for rabbitmq #5884 and Updatepants-plugins/uses_servicesto support checking for redis #5893.