GHA workflow to run (some) tests via pantsbuild #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
cognifloyd
force-pushed
the
pants-ci-test
branch
from
3a982c5
to
102d70e
Compare
cognifloyd
force-pushed
the
pants-ci-test
branch
from
edbe2b6
to
36fb243
Compare
cognifloyd
requested review from
amanda11,
rush-skills,
arm4b,
winem,
nzlosh and
a team
cognifloyd
force-pushed
the
pants-ci-test
branch
4 times, most recently
from
9efc024
to
63f4ac6
Compare
nzlosh
approved these changes
Dec 31, 2022
amanda11
approved these changes
Jan 3, 2023
cognifloyd
force-pushed
the
pants-ci-test
branch
from
63f4ac6
to
0e6dc46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
This adds a
TestGHA workflow that uses pants to run tests. Our test suite does not support running via pytest (which is what pants uses), so this workflow only runs tests onpylint_plugins/andpants-plugins/. We can slowly expand this as we get more of our tests runnable under pytest.The reason I'm doing this now: I want to add tests for plugins that will go in
pants-plugins/, and I want to use pants to run those tests.pylint_plugins/serves as a starting point to show that testing is doing something before we add those pants plugins and related tests.#5849 was split off of this PR to make review easier. #5849 is required before this PR can be rebased and then merged.