clone packs into user_home/.st2packs directory #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
|
@cognifloyd @armab Will this change effect any of our build pipelines? |
cognifloyd
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
I don't see any problems with this, and I don't think it will affect any other tooling or scripts. I didn't realize we were directly using the home directory, so this feels much better.
Please use double quotes on the string (or run black to reformat which will do the same).
rush-skills
approved these changes
Feb 3, 2023
Openshift does not allow packs to be cloned to home directory as they are mounted at `/`. Proposing to use a directory `.st2packs` in home directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openshift does not allow packs to be cloned to home directory as they are mounted at
/. Proposing to use a directory.st2packsin home directory.