Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop st2exporter #5676

Merged
merged 10 commits into from
Jul 24, 2022
Merged

Drop st2exporter #5676

merged 10 commits into from
Jul 24, 2022

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Jul 18, 2022

Removed st2exporter service. It is unmaintained and does not get installed. It was originally meant to help with analytics by exporting executions as json files that could be imported into something like elasticsearch. Our code is now instrumented to make a wider variety of stats available to metrics drivers.

Requires StackStorm/st2-packages#723
Closes #5295
Closes StackStorm/st2-packages#367

@cognifloyd cognifloyd added this to the 3.8.0 milestone Jul 18, 2022
@cognifloyd cognifloyd self-assigned this Jul 18, 2022
@pull-request-size pull-request-size bot added the size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several. label Jul 18, 2022
@cognifloyd cognifloyd requested a review from a team July 18, 2022 22:24
Copy link
Member

@rush-skills rush-skills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
I had a question wrt DB changes - will all existing st2exporter-related DB entries (marker, etc.) be automatically purged with these changes? Or is that something we make st2garbagecollector handle?

@cognifloyd
Copy link
Member Author

@rush-skills Good call. I added a migration util that can drop the marker collections.
I expect most people will not have the collections because we have not shipped st2exporter in years, and the collection doesn't get created automatically. My prod instance, which has been around since the early days of st2, does not have these collections. But, if someone does, here's a script to delete it.

@cognifloyd cognifloyd requested a review from a team July 21, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics pantsbuild refactor size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several. st2-packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove st2exporter st2exporter is abandoned
3 participants