-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unused dependencies #5228
Drop unused dependencies #5228
Conversation
c81a588
to
103ef35
Compare
prometheus_client was part of a metrics driver that was dropped. python-gnupg was dropped with the removal of st2debug. zipp and more-itertools were py2-only transitive deps.
103ef35
to
7329ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but perhaps add a CHANGELOG entry
This is cleanup missed from previous PRs that removed the dependencies. I don't think it warrants a changelog entry. |
@cognifloyd For context, which PR # and changelog entry you're referring to? |
@armab That's a bit of a fishing expedition to ask somebody to go on, don't you think? And I don't understand how the results would matter. I agree with @cognifloyd, I don't know that this is really a big enough change on its own to warrant a line in the changelog. This isn't going to change any user-facing code. |
I believe having a Changelog record helps a lot for both users and developers and agree that having it would be nice for consistency with the engineering flow. |
To make it simple the changelog could just say remove unused dependencies - rather than needing a full investigation to work out exactly when those dependencies were removed. It states the point of the change, but doens't require lots of effort for what is a nice clean up - which is always appreciated. |
I think that's too much noise in the changelog for something like this. I did all that research when I validated that these were not needed. Let me do it again to provide info. I'll update the original post with details as I find it. |
|
I don't think a changelog entry adds any value, so I'm not sure what to write. |
Something simple like this would be totally fine: * Cleanup unused ``pip`` dependencies (improvement). #5228
Contributed by @cognifloyd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, the more stuff we can remove, the better 👍
But yeah, please still add a changelog entry for just in case.
Eventually we could also still removing all the Python 2 / 3 compatibility boiler plate and also get rid of |
And re changelog entry - IIRC, anything from StackStorm virtualenv is also available to pack virtualenv (but I could also be wrong on that since that behavior had some edge cases and has changed in the past) so in theory a pack could be depending on some of those dependencies without specifying them in So if that's indeed still true / accurate, then it would make sense to explicitly list those dependencies in the changelog entry. |
prometheus_client
was part of a metrics driver that was dropped. #4310 (82772cc) #4504 (873c57f) unused since v2.9.0zipp
andmore-itertools
were py2-only transitive deps. #4843 #4847 (afaict these were transitive deps viawheel
) added in v3.2.0; unused since v3.4.0 when we dropped python 2python-gnupg
was dropped with the removal of st2debug. #5103 unused since v3.4.0background: I discovered this as part of an experiment using pants in st2sandbox/st2@pants to replace the Makefile and related scripts.