Update various core and test dependencies to latest stable version #5215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
Member
Author
|
To confirm there are no performance regressions (at least for the operations we have micro benchmarks for) in mongoengine / pymongo, I ran micro-benchmarks I added not too long ago and compared the results under different versions (0.18.0, 0.23.0). |
amanda11
approved these changes
Mar 31, 2021
Contributor
amanda11
left a comment
amanda11
left a comment
There was a problem hiding this comment.
LGTM - just changelog missing.
1 task
4 tasks
cognifloyd
added a commit
to cognifloyd/stackstorm-vault
that referenced
this pull request
May 29, 2021
For some reason the ssl module is hitting an infinite recursion error. This might be CircleCI-specific, depending on the openssl lib they used to compile python. The 3.7.0 version is supposed to be even more robust, so it could also be something about v3.6.13. I have not reproduced the error elsewhere, however. The error began appearing after we updated requests from v2.23.0 to v2.25.1 in StackStorm/st2#5215 In requests v2.24.0, it defaulted to using the python ssl module instead of PyOpenSSL due to various SELinux issues. Before that it used PyOpenSSL whenever it was installed. Since it worked with pyopenssl, we just revert to using it for the tests in this repo. See: psf/requests#5443
cognifloyd
added a commit
to cognifloyd/stackstorm-vault
that referenced
this pull request
May 29, 2021
For some reason the ssl module is hitting an infinite recursion error. This might be CircleCI-specific, depending on the openssl lib they used to compile python. The 3.7.0 version is supposed to be even more robust, so it could also be something about v3.6.13. I have not reproduced the error elsewhere, however. The error began appearing after we updated requests from v2.23.0 to v2.25.1 in StackStorm/st2#5215 In requests v2.24.0, it defaulted to using the python ssl module instead of PyOpenSSL due to various SELinux issues. Before that it used PyOpenSSL whenever it was installed. Since it worked with pyopenssl, we just revert to using it for the tests in this repo. See: psf/requests#5443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes some book keeping and upgrades various deps to latest stable versions.
Core dependencies:
Test dependencies:
There were some small backward incompatible changes in mongoengine which were caught by tests and fixed.
TODO