-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Rules that are renamed/removed not removed on reload #924
Comments
Seems like the old rule is not removed. |
True for actions also PWH
|
@manasdk yeah, I probably said it confusingly... but that's what I am trying to relay. |
Was the name of the rule changed? |
@manasdk the name changed, yes... from |
Looks like I missed this ticket. To clarify it, this is a feature and not a bug. We update all the resources in the DB when registration script is called, but we never delete them - we only delete them when user explicitly uninstalls a pack. |
Looks like a feature. Close the issue? |
I don't like this as a feature. If I delete something from my infra as code repository, I expect it gone. How do I reconcile this? |
Yeah we are deviating from the infrastructure as code promise to some extent. With the DB and filesystem as 2 sources of truth we will need to add some code to reconcile the sources. It is an issue that we have brushed under the rug since there is a way to clean up old content. |
I ended up changing the namespace for my CI/CD workflow... from a url of
cicd/github/events
tocicd/events
. On a reload however, the old endpoint is still registered.Should this be removed, as it is no longer a defined endpoint? It is what I would expect to happen.
The text was updated successfully, but these errors were encountered: