Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Rules that are renamed/removed not removed on reload #924

Open
jfryman opened this issue Dec 19, 2014 · 9 comments
Open

BUG: Rules that are renamed/removed not removed on reload #924

jfryman opened this issue Dec 19, 2014 · 9 comments
Labels

Comments

@jfryman
Copy link
Contributor

jfryman commented Dec 19, 2014

I ended up changing the namespace for my CI/CD workflow... from a url of cicd/github/events to cicd/events. On a reload however, the old endpoint is still registered.

Should this be removed, as it is no longer a defined endpoint? It is what I would expect to happen.

10_20_30_2_3000___rules_548a2a07dc837b438b07d8dd_general

@manasdk
Copy link
Contributor

manasdk commented Dec 19, 2014

Seems like the old rule is not removed.

@st2stanley
Copy link
Contributor

True for actions also

PWH
On Dec 19, 2014 11:00 AM, "Manas Kelshikar" [email protected]
wrote:

Seems like the old rule is not removed.


Reply to this email directly or view it on GitHub
#924 (comment).

@jfryman
Copy link
Contributor Author

jfryman commented Dec 19, 2014

@manasdk yeah, I probably said it confusingly... but that's what I am trying to relay.

@manasdk
Copy link
Contributor

manasdk commented Dec 19, 2014

Was the name of the rule changed?

@jfryman
Copy link
Contributor Author

jfryman commented Dec 19, 2014

@manasdk the name changed, yes... from st2.webhook.cicd.github.events -> st2.webhook.cicd.events

@Kami Kami added bug and removed bug labels Jan 5, 2015
@Kami
Copy link
Member

Kami commented Jan 5, 2015

Looks like I missed this ticket.

To clarify it, this is a feature and not a bug. We update all the resources in the DB when registration script is called, but we never delete them - we only delete them when user explicitly uninstalls a pack.

@manasdk
Copy link
Contributor

manasdk commented Apr 14, 2015

Looks like a feature. Close the issue?

@jfryman
Copy link
Contributor Author

jfryman commented Apr 14, 2015

I don't like this as a feature. If I delete something from my infra as code repository, I expect it gone. How do I reconcile this?

@manasdk
Copy link
Contributor

manasdk commented Apr 14, 2015

Yeah we are deviating from the infrastructure as code promise to some extent. With the DB and filesystem as 2 sources of truth we will need to add some code to reconcile the sources.

It is an issue that we have brushed under the rug since there is a way to clean up old content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants