Skip to content

Commit

Permalink
Update to pants 2.14 (final) (#5817)
Browse files Browse the repository at this point in the history
* pants: silence un-actionable unowned dep warnings

* bump to pants 2.14.0

* update changelog entry
  • Loading branch information
cognifloyd authored Nov 30, 2022
1 parent ec2d399 commit eba62dd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Added
* Continue introducing `pants <https://www.pantsbuild.org/docs>`_ to improve DX (Developer Experience)
working on StackStorm, improve our security posture, and improve CI reliability thanks in part
to pants' use of PEX lockfiles. This is not a user-facing addition.
#5778 #5789
#5778 #5789 #5817
Contributed by @cognifloyd


Expand Down
12 changes: 11 additions & 1 deletion pants.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ enabled = false
repo_id = "de0dea7a-9f6a-4c6e-aa20-6ba5ad969b8a"

[GLOBAL]
pants_version = "2.14.0rc3"
pants_version = "2.14.0"
backend_packages = [
# python
"pants.backend.python",
Expand Down Expand Up @@ -84,6 +84,16 @@ root_patterns = [
"/st2common/benchmarks/micro",
]

[python-infer]
# https://www.pantsbuild.org/docs/reference-python-infer#unowned_dependency_behavior
# The default changed from "ignore" to "warning" in pants 2.14.
# Many of the new warnings however have been adressed via explicit deps,
# so the warnings are not helpful. In pants 2.16, a "visibility" feature might help
# us to disambiguate deps between files without those explicit BUILD dependencies,
# and without adding "# pants: no-infer-dep" comments all over the codebase.
# Revisit this in pants 2.16 to see if it is feasible to use the default "warning".
unowned_dependency_behavior = "ignore"

[bandit]
lockfile = "lockfiles/bandit.lock"
version = "bandit==1.7.0"
Expand Down

0 comments on commit eba62dd

Please sign in to comment.