Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up setup.py #10

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Clean up setup.py #10

merged 1 commit into from
Mar 14, 2023

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Mar 14, 2023 •
edited
Loading

Drop problematic pip version check that can break pants/pex lockfile generation. Also, update python classifiers to 3.6-3.8 and bump the version.

@cognifloyd cognifloyd self-assigned this Mar 14, 2023
@cognifloyd cognifloyd requested a review from a team March 14, 2023 06:14
rush-skills
rush-skills approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@rush-skills rush-skills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cognifloyd cognifloyd merged commit dee24df into master Mar 14, 2023
@cognifloyd cognifloyd mentioned this pull request Mar 14, 2023
Closed
@cognifloyd cognifloyd deleted the clean-setup branch June 11, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rush-skills rush-skills rush-skills approved these changes

Assignees

@cognifloyd cognifloyd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cognifloyd @rush-skills