Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook mediatype for Zabbix 6.0 or higher #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add webhook mediatype for Zabbix 6.0 or higher #60

wants to merge 1 commit into from

Conversation

masa-orca
Copy link

Dear maintainers.

I implemented webhook dispatcher for the Zabbix 6.0.

I haven't done any test about st2 actions against Zabbix v6.0.

Will you review my pull requests?

sincerely.

@masa-orca masa-orca requested review from a team and namachieli as code owners November 9, 2023 17:07
@masa-orca masa-orca requested review from Kami and removed request for a team November 9, 2023 17:07
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@masa-orca masa-orca force-pushed the webhook branch 8 times, most recently from 3422a75 to 0ce6a94 Compare November 10, 2023 18:21
@masa-orca masa-orca marked this pull request as draft November 10, 2023 18:24
@masa-orca masa-orca force-pushed the webhook branch 3 times, most recently from b8b7b3f to f96a523 Compare November 10, 2023 18:45
@masa-orca masa-orca marked this pull request as ready for review November 10, 2023 18:48
@masa-orca masa-orca force-pushed the webhook branch 2 times, most recently from baf4508 to 7206ea4 Compare November 10, 2023 18:53
@masa-orca
Copy link
Author

Hi reviewers.
Let me know status of this pull request and what tasks I need to do !

@namachieli
Copy link
Collaborator

Hi,

First off, thank you for the excellent PR, this looks great. Second, I apologize for the delay on approval, I just started a new job a few months ago and its been busy.

Regarding testing actions against 6.0: I'm currently running Zabbix 6.0.25 with the current version of this pack, and I have not (yet) ran into issues.

The only concern I have is these changes potentially breaking compatibility with older versions of Zabbix that this pack currently is working for.

I'm thinking this may be a goo point to increment the pack version to 2.0.0 rather than 1.1.0. At some point it will become too arduous to support so many major versions of Zabbix.

What are your thoughts on this @masa-orca ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namachieli namachieli Awaiting requested review from namachieli namachieli is a code owner

@Kami Kami Awaiting requested review from Kami Kami is a code owner automatically assigned from StackStorm-Exchange/tsc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masa-orca @CLAassistant @namachieli