-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gitpython 3.0.0 to 3.1.40 #14
Conversation
Hi, the problem looks that gitpython need 3.7 and higher. Is it possible to change the test Pipeline to 3.8 like the actual Version of stackstorm ? See: GitPython needs the git executable to be installed on the system and available in your PATH for most operations. If it is not in your PATH, you can help GitPython find it by setting the GIT_PYTHON_GIT_EXECUTABLE=<path/to/git> environment variable.
|
Update CI Setting to Python 3.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Very helpful to get it updated security-wise.
Left several comments before we can merge it.
Co-authored-by: Eugen C. <[email protected]>
Co-authored-by: Eugen C. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@@ -15,3 +15,4 @@ jobs: | |||
enable-common-libs: true | |||
#apt-cache-version: v0 | |||
#py-cache-version: v0 | |||
python-version: "3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remembered one more thing,
stackstorm-git/.github/workflows/release.yaml
Lines 12 to 20 in 2024415
jobs: | |
# This mirrors build_and_test workflow | |
build_and_test: | |
name: 'Build and Test' | |
uses: StackStorm-Exchange/ci/.github/workflows/pack-build_and_test.yaml@master | |
with: | |
enable-common-libs: true | |
#apt-cache-version: v0 | |
#py-cache-version: v0 |
needs adding python-version: "3.8"
too.
That release workflow will run after merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thank you for all your Feedback :)
One more change is needed for release workflow
Update gitpython 3.0.0 to 3.1.40
Close some Snyk Sec fingings:
https://security.snyk.io/vuln/SNYK-PYTHON-GITPYTHON-5840584
https://app.snyk.io/vuln/SNYK-PYTHON-GITPYTHON-3113858
https://app.snyk.io/vuln/SNYK-PYTHON-GITPYTHON-5871282
https://app.snyk.io/vuln/SNYK-PYTHON-GITPYTHON-5876644
https://app.snyk.io/vuln/SNYK-PYTHON-GITPYTHON-2407255
Change CI Python Version from 3.6 to 3.8 because the actual gitpython version works only with >= 3.7.
Drop Python 3.6 support.