-
Notifications
You must be signed in to change notification settings - Fork 26
Add boto3action to aws pack #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d json_serial into lib
boto3action.md
Outdated
| `aws.boto3action` runs boto3 actions in stackstorm dynamically. It has following features. | ||
|
|
||
| - Uses boto3 configurations. Find more information on boto3 configuration in boto3 documentation. http://boto3.readthedocs.io/en/latest/guide/quickstart.html#configuration | ||
| - Ablity to run cross region actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ablity -> Ability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the latest commit.
boto3action.md
Outdated
|
|
||
| - Uses boto3 configurations. Find more information on boto3 configuration in boto3 documentation. http://boto3.readthedocs.io/en/latest/guide/quickstart.html#configuration | ||
| - Ablity to run cross region actions | ||
| - Ablility to run cross account actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ability -> Ability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the latest commit.
warrenvw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm asking for a few minor tweaks. Before we merge boto3 into master, we'll make sure that all outstanding issues are resolved, and users are notified of the upcoming changes.
|
@warrenvw Thanks for approving changes. Please let me know if you need anything from me to make progress on this PR. |
humblearner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I create this pull request as a result of discussion happened in, StackStorm-Exchange/exchange-incubator#10. Main features in this pull request are,
For example, I have a st2 deployment in aws account 123456 and us-east-1. I want to deploy VPC in account 456789 and us-west-1.
In addition,
aws.boto3actioncreated with following opinions.Boto3 is the official SDK for AWS. As a user/developer, If I have boto3 configured I expect
awspack to work without doing any additional configuration. For example,In addition, if I want to use use boto3 profiles
yaml generation
Long term, I don’t believe yaml generation scale based on the number of services AWS have and introduce. In addition, IMO Boto3 documentation is detailed, has examples. Having yaml for each action is redundant and add no value to the end user.
pack maintenance
Since there are no yaml to generate, this pack should be easy to maintain. Any new service boto3 introduce, available to pack user right away.