-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update default python version for packs to be a list #143
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sravs-dev Thanks for the PR!
Let's verify if it works in a pack CI.
You can open a PR in some Exchange pack repo. Let's pick up Github
pack, the workflow is here: https://github.com/StackStorm-Exchange/stackstorm-github/blob/master/.github/workflows/build_and_test.yaml#L13
You can open a PR changing the ref to your fork with a branch.
That should use this GH Workflow and we can verify if it works OK.
Please also sign CLA.
@@ -14,7 +14,7 @@ on: | |||
python-version: | |||
required: false | |||
type: string | |||
default: "3.6" | |||
default: ["3.6","3.8","3.9"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the type from string to array here would mean we have to change the matrix definition below. There, we are using matrix.include
to add one entry for the indicated python version.
The docs about matrix.include
are here.: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations
@armab I have signed the CLA, but it still shown as pending. Could you please help? |
@sravs-dev Might be because you created commits on behalf of @sravanthi-konduru github account, but signed CLA as @sravs-dev? The CLA needs to be signed from the commit owner account. |
2578e86
to
73b13c0
Compare
No description provided.