Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default python version for packs to be a list #143

Closed

Conversation

sravs-dev
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sravs-dev Thanks for the PR!

Let's verify if it works in a pack CI.
You can open a PR in some Exchange pack repo. Let's pick up Github pack, the workflow is here: https://github.com/StackStorm-Exchange/stackstorm-github/blob/master/.github/workflows/build_and_test.yaml#L13
You can open a PR changing the ref to your fork with a branch.

That should use this GH Workflow and we can verify if it works OK.

Please also sign CLA.

@@ -14,7 +14,7 @@ on:
python-version:
required: false
type: string
default: "3.6"
default: ["3.6","3.8","3.9"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the type from string to array here would mean we have to change the matrix definition below. There, we are using matrix.include to add one entry for the indicated python version.

The docs about matrix.include are here.: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations

@sravs-dev
Copy link
Contributor Author

@armab I have signed the CLA, but it still shown as pending. Could you please help?

@arm4b
Copy link
Member

arm4b commented Dec 2, 2023

@sravs-dev Might be because you created commits on behalf of @sravanthi-konduru github account, but signed CLA as @sravs-dev? The CLA needs to be signed from the commit owner account.

@sravs-dev
Copy link
Contributor Author

@armab opened a new PR to resolve commit log issues. Closing this one

@sravs-dev sravs-dev closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants