Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORKBUN: support CAA #3200

Merged
merged 1 commit into from
Nov 12, 2024
Merged

PORKBUN: support CAA #3200

merged 1 commit into from
Nov 12, 2024

Conversation

imlonghao
Copy link
Contributor

close #3199

Testes passed

CAA with whitespace not supported.

=== RUN   TestDNSProviders/example.com/33:CAA:CAA_whitespace
    integration_test.go:248:
        ± MODIFY example.com CAA (128 issuewild ";" ttl=600) -> (0 issue "letsencrypt.org; validationmethods=dns-01; accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234" ttl=600), porkbun ID: 437665127
    integration_test.go:269: Expected 0 corrections on second run, but found 1.
    integration_test.go:271: UNEXPECTED #0: ± MODIFY example.com CAA (0 issue "letsencrypt.org;" ttl=600) -> (0 issue "letsencrypt.org; validationmethods=dns-01; accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234" ttl=600), porkbun ID: 437665127

@tlimoncelli
Copy link
Contributor

I love when a new feature can be added so simply!

Please run go generate and commit the new documentation/providers.md file.

Thanks!

@imlonghao
Copy link
Contributor Author

done.

@tlimoncelli tlimoncelli merged commit 5d8e711 into StackExchange:main Nov 12, 2024
2 checks passed
@imlonghao imlonghao deleted the porkbun/caa branch November 17, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porkbun does not support CAA records
3 participants