chore: Replaces string interpolation with structured logging - ResultProcessor #2925
+108
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces manual string interpolation with compile-time generated LoggerMessage methods for better performance and structured logging. Adds 16 new LoggerMessage extension methods covering response logging and auto-configuration scenarios for Redis server connections. Improves logging efficiency by eliminating runtime string formatting overhead and enables better log analysis through consistent message templates.
5 tasks
Meir017
changed the title
mgravell
reviewed
Jul 24, 2025
| { | ||
| server.ReplicaReadOnly = true; | ||
| Log?.LogInformation($"{Format.ToString(server)}: Auto-configured (CONFIG) read-only replica: true"); | ||
| Log?.LogInformationAutoConfiguredConfigReadOnlyReplicaTrue(new(server)); |
There was a problem hiding this comment.
Can we merge I have merged these two and make the true/false a bool parameter? I'm fine with the case changing if we use default logging
|
LGTM (with tweak), thanks |
mgravell
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2899
Replaces manual string interpolation with compile-time generated LoggerMessage methods for better performance and structured logging.
Adds 16 new LoggerMessage extension methods covering response logging and auto-configuration scenarios for Redis server connections.
Improves logging efficiency by eliminating runtime string formatting overhead and enables better log analysis through consistent message templates.
satisfying!
redis-logging-pr.mp4