Skip to content

client library metadata should validate contents #2653

@mgravell

Description

@mgravell

The client setinfo lib-name and client setinfo lib-ver sub-commands are picky:

127.0.0.1:6379> client setinfo lib-name "a b"
(error) ERR lib-name cannot contain spaces, newlines or special characters.
127.0.0.1:6379> client setinfo lib-name "a-b"
OK

and

127.0.0.1:6379> client setinfo lib-ver "a b"
(error) ERR lib-ver cannot contain spaces, newlines or special characters.
127.0.0.1:6379> client setinfo lib-ver "a-b"
OK

This causes the library metadata to not be set at all; suggestion: fix this at the library level. We already perform client setname validation, removing invalid characters; however, I propose to replace any groups of invalid characters with a single - instead, to retain semantic grouping. I do not currently propose to change how client setname sanitizes anything, although that could also be considered.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions