DSL Widgets : added StacDrawer, StacDefaultTabController, StacPageView, StacTab, StacTabBarStac, TabViewParser #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potatomonsta
force-pushed
the
p2-widgets
branch
from
2cb8aa1 to
eb5591a
Compare
|
@Potatomonsta PR checks are failing. Please check it. |
divyanshub024
requested changes
Aug 16, 2025
| initialIndex: model.initialIndex, | ||
| child: Stac.fromJson(model.child, context) ?? const SizedBox(), | ||
| initialIndex: model.initialIndex ?? 0, | ||
| child: model.child.parse(context) ?? const SizedBox(), |
There was a problem hiding this comment.
Duration field is missing here. Can we add stac duration?
| @@ -1,11 +1,11 @@ | |||
| import 'package:flutter/material.dart'; | |||
| import 'package:stac/src/framework/framework.dart'; | |||
| // Removed unused framework import | |||
There was a problem hiding this comment.
We don't need this comment
| itemCount: widget.model.children.length, | ||
| dragStartBehavior: widget.model.dragStartBehavior, | ||
| allowImplicitScrolling: widget.model.allowImplicitScrolling, | ||
| itemCount: widget.model.children?.length ?? 0, |
There was a problem hiding this comment.
item count doesn't need default 0 value. It can be nullable.
| indicator: model.indicator?.parse(context), | ||
| indicatorSize: model.indicatorSize, | ||
| labelColor: model.labelColor.toColor(context), | ||
| indicatorSize: () { |
There was a problem hiding this comment.
This should be part of the parse method.
| dividerColor: model.dividerColor.toColor(context), | ||
| tabAlignment: () { | ||
| switch (model.tabAlignment) { | ||
| case StacTabAlignment.center: |
There was a problem hiding this comment.
This should be part of the parse method.
divyanshub024
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added StacDrawer, StacDefaultTabController, StacPageView, StacTab, StacTabBarStac, TabViewParser and required enums
Type of Change