Get the intermediate certificate whenever needed #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intermediate certificate was currently retrieved locally only for the 1st certificate generation. This causes issues when the intermediate cerficiate changes (recent change from X3 to R3) and the certificates just need to be renewed. This patch moves the retrieval of the intermediate certificate along with the certificate creation to be sure the former exists before being attached to the latter.
|
Note: this is required for #63 to work correctly when renewing certificates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intermediate certificate was currently retrieved locally only for
the 1st certificate generation.
This causes issues when the intermediate cerficiate changes (recent
change from X3 to R3) and the certificates just need to be renewed.
This patch moves the retrieval of the intermediate certificate along
with the certificate creation to be sure the former exists before being
attached to the latter.