Specify minimum rust version #1127
Conversation
|
Cool, didn't know that. LGTM! I wonder if we could also pin that version in CI (not CD) so that we notice, when we need to bump the MSRV. Edit: See for example how |
|
Good idea @eladyn. I've added that to this MR. |
|
Oh wait, that broke everything. |
|
Ok, we're good now. |
.github/workflows/ci.yml
Outdated
| toolchain: | ||
| - "1.62" |
There was a problem hiding this comment.
That shouldn't be needed, since you aren't using ${{ matrix.toolchain }} anywhere.
|
Fantastic, LGTM :) These are almost the exact changes I made in response to #1123 , which this also fixes (and im going to sneakily link to this now ;)) I'm going to make some small changes to CI to ensure we're still getting the most recent lints |
This improves the error reporting when the crate is compiled with older versions of rustc. Specifically, #1123 tracks instances of Ubuntu rustc giving obscure errors when users attempt to compile spotifyd With this change, this error becomes > error: package `spotifyd v0.3.3 (...)` cannot be built because it requires rustc 1.62 or newer, while the currently active rustc version is 1.61.0 which is much more helpful to users diagnosinig the issue.
There was a problem hiding this comment.
assuming the CI is happy, lets get this done! It'd be nice to have a landing page in the documentation for the error ubuntu users will get:
error: package `spotifyd v0.3.3 (...)` cannot be built because it requires rustc 1.62 or newer, while the currently active rustc version is 1.61.0
|
agh, clippy 🙄 fine, will make a quick PR for those |
Resolves #1126