-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Spoolman enrichment on reader + writer pages (#97) #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c952a08
chore: add .worktrees/ to .gitignore
sjordan0228 4381d4b
feat: add density and diameter_mm to SpoolDetails, parse from Spoolma…
sjordan0228 a679022
feat: trigger Spoolman UID lookup for smart tags, store SmartTagEnric…
sjordan0228 34209ae
feat: expose smart tag Spoolman enrichment in /api/status, add find-v…
sjordan0228 cd20abe
feat: show Spoolman enrichment badges on reader page for smart tags
sjordan0228 bc8c26e
feat: add Spoolman Enrichment section and Read button HTML to writer …
sjordan0228 d1aefbe
feat: Read button flow — poll for tag, fill writer form from tag data…
sjordan0228 a3d0393
feat: extend Write Tag flow to save Spoolman enrichment after NFC wri…
sjordan0228 cdc52f8
feat: add Read button to OPT writer page for re-write flow
sjordan0228 c603e01
fix: collapse OpenSpool enrichment bed temp to single field (Spoolman…
sjordan0228 4125150
fix: reader enrichment polling, enrichment persistence after tag remo…
sjordan0228 ffee0af
fix: CodeRabbit findings — remaining_g min=1, vendor/filament decline…
sjordan0228 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,3 +25,4 @@ CODE-REVIEW.md | |
| test-preview/ | ||
| .gstack/ | ||
| build/ | ||
| .worktrees/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore stale lookup results, and do not gate the cache on
display_.The new
smartTagEnrichment_write sits insideif (display_), so display-disabled units never populate/api/status.spoolman. This block also only inspectsstate.kind; it does not verifystate.presentandstate.spool_id == msg.payload.spoolmanSynced.spool_id, so a delayed lookup for tag A can overwrite the cache or LCD while tag B is on the reader. Reuse the same presence/UID guard from Lines 701-709 before updating either the cache or the display.Also applies to: 761-770
🧰 Tools
🪛 Clang (14.0.6)
[note] 724-724: +1, including nesting penalty of 0, nesting level increased to 1
(clang)
[note] 725-725: +2, including nesting penalty of 1, nesting level increased to 2
(clang)
[note] 725-725: +1
(clang)
[note] 730-730: +1
(clang)
[note] 734-734: +3, including nesting penalty of 2, nesting level increased to 3
(clang)
[note] 740-740: +4, including nesting penalty of 3, nesting level increased to 4
(clang)
[note] 746-746: +1, nesting level increased to 3
(clang)
[warning] 724-724: implicit conversion 'DisplayI *' -> bool
(readability-implicit-bool-conversion)
[warning] 740-740: statement should be inside braces
(readability-braces-around-statements)
[warning] 742-742: floating point literal has suffix 'f', which is not uppercase
(readability-uppercase-literal-suffix)
🤖 Prompt for AI Agents