Add files via upload#165
Merged
sjordan0228 merged 7 commits intoApr 20, 2026
Merged
Conversation
Contributor
roomonthethird
commented
Apr 19, 2026
roomonthethird
commented
When a spool is selected from the Spoolman picker and Write Tag is clicked, the JS calls POST /api/spoolman/pending-link with the selected spool ID before waiting for a tag. The firmware stores this pending link and on the next tag detection, PATCHes nfc_id on the existing spool instead of auto-creating a duplicate. Pending link expires after 2 minutes if no tag is detected. - SpoolmanManager: setPendingLink(), atomic pendingLinkSpoolId_ + expiry - WebServerManager: POST /api/spoolman/pending-link endpoint - SharedJS: track _selectedSpoolId in picker, call pending-link at write start
Store timestamp before spool ID in setPendingLink so any reader that sees a valid ID is guaranteed the timestamp is already set. Read timestamp before the exchange in syncSpool to match.
…pgrade PlatformIO auto-updated to espressif32@53.3.10 (Arduino ESP32 3.x / ESP-IDF 5.x) which has breaking API changes. Pin to last known-good 2.x-based platform version.
…-pending-link fix: link existing Spoolman spool when writing tag from picker (SpoolSense#130)
- Firefox stale-cache fix: no-store + compile-time ?v=FIRMWARE_VERSION (SpoolSense#151) - Default initial_weight to 1000g when Spoolman has no weight set (SpoolSense#128) - Writer Read enrichment polling — async Spoolman lookup with 8s retry (SpoolSense#101) - Format detection grace period — 2s tolerance before wrong-format error (SpoolSense#101) - Full round-trip field restoration on writer Read (SpoolSense#101)
- Bambu MIFARE Classic tag reading via HKDF key derivation + PN5180 auth (SpoolSense#24) - Reads material, color, weight, diameter, temps, production date, filament length - TFT display, web reader page, MQTT/HA publishing, Spoolman sync
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (5)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
I don't think I added this correctly...I created a Spoolsense case for ESP32 S3 mini and the PN5180. No headers used but directly soldered. Please let me know how I can correctly upload files as this is my first time lol. |
This was referenced Apr 20, 2026
roomonthethird
pushed a commit
to roomonthethird/spoolsense_scanner
that referenced
this pull request
Apr 22, 2026
Bumps FIRMWARE_VERSION from 1.7.2 → 1.7.3. CHANGELOG.md: - Adds [1.7.3] entry documenting SpoolSense#163 WiFi keep-awake, SpoolSense#165 case files, SpoolSense#164/SpoolSense#13 TigerTag partial writes, SpoolSense#159/SpoolSense#162 openprinttag rename. - Backfills missing [1.7.2] entry (Bambu MIFARE Classic reading, SpoolSense#24). - Backfills missing [1.7.1] entry (writer enrichment + bug fixes, SpoolSense#130/SpoolSense#101/SpoolSense#128/SpoolSense#151 and platform pin).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.