cleanup: remove TIMING debug instrumentation

[sjordan0228]

Remove millis() timing captures and TIMING printf lines from detectTag, readISO14443Pages, and prepareRF. Debug instrumentation from PN5180 reliability work — no longer needed.

Summary by CodeRabbit

Release Notes

• Chores
  • Removed internal timing instrumentation from NFC connection management to improve code clarity.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8e122049-022f-4b91-9d43-92382d827ba4

📥 Commits

Reviewing files that changed from the base of the PR and between 9811258 and 1e8f049.

📒 Files selected for processing (2)

• src/HardwareNFCConnection.cpp
• src/NFCManager.cpp

---

📝 Walkthrough

Walkthrough

The PR removes millis()-based timing instrumentation from NFC hardware and manager components. Timing variables and debug output are eliminated from HardwareNFCConnection and NFCManager methods. Underlying control flow and tag session management remain unchanged.

Changes

Cohort / File(s)	Summary
Timing Instrumentation Removal src/HardwareNFCConnection.cpp, src/NFCManager.cpp	Removed millis() based timing measurements and related Serial.printf timing output from detectTag(), readISO14443Pages(), and prepareRF() methods. Simplified error logging in tag reactivation failure case. Control flow and state management preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• refactor: reduce cyclomatic complexity in NFCManager + WebServerManager #121: Also modifies NFCManager::prepareRF(), potentially with overlapping or conflicting changes to this method's implementation.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cleanup/remove-timing-instrumentation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}