Skip to content

feat: add keypad and Moonraker URL prompts to installer#9

Merged
sjordan0228 merged 2 commits into
devfrom
feature/keypad-moonraker
Mar 27, 2026
Merged

feat: add keypad and Moonraker URL prompts to installer#9
sjordan0228 merged 2 commits into
devfrom
feature/keypad-moonraker

Conversation

@sjordan0228
Copy link
Copy Markdown
Contributor

@sjordan0228 sjordan0228 commented Mar 27, 2026

Summary

  • Adds "3x4 matrix keypad attached?" prompt to Optional Hardware section
  • Adds "Klipper / Moonraker printer?" prompt with Moonraker URL (default http://localhost:7125)
  • Writes keypad_on and moonraker_url to NVS partition
  • Documents both keys in nvs_keys.csv

Companion to SpoolSense/spoolsense_scanner#46.

Test plan

  • Run installer, verify keypad prompt appears after LED prompt
  • Verify Moonraker URL prompt only appears if user says Yes to Klipper
  • Verify NVS CSV includes keypad_on and moonraker_url values
  • Config-only mode also includes the new prompts

Summary by CodeRabbit

  • New Features

    • Added interactive setup prompts during installation for keypad configuration (3x4 matrix keypad)
    • Added optional Klipper/Moonraker printer integration setup
  • Style

    • Configuration file formatting updates

- Optional Hardware section: adds "3x4 matrix keypad attached?" prompt
- Printer Integration section: asks if Klipper/Moonraker, prompts for URL
- NVS CSV: writes keypad_on and moonraker_url to NVS partition
- nvs_keys.csv: documents both new keys
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 27, 2026

Warning

Ignoring CodeRabbit configuration file changes. For security, only the configuration from the base branch is applied for open source repositories.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9e0f00f1-2bc3-494c-9d34-2652785d111b

📥 Commits

Reviewing files that changed from the base of the PR and between 3b72b67 and de77428.

⛔ Files ignored due to path filters (1)
  • nvs_keys.csv is excluded by !**/*.csv
📒 Files selected for processing (2)
  • .coderabbit.yaml
  • install.py

📝 Walkthrough

Walkthrough

The PR updates the CodeRabbit configuration with reformatted instructions block indentation, and extends the installer script with interactive prompts for keypad hardware and optional Moonraker printer integration, storing these settings in the scanner configuration and NVS CSV output.

Changes

Cohort / File(s) Summary
Configuration Formatting
.coderabbit.yaml
Re-indented the reviews.instructions block with additional leading spaces; no content changes.
Installer Enhancements
install.py
Added interactive prompts for keypad hardware (keypad_on), Klipper/Moonraker printer integration, and moonraker_url input with validation and default value. Extended returned configuration dict and NVS CSV generation to include new settings as u8 and string types respectively.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: adding keypad and Moonraker URL prompts to the installer, which aligns with the core functionality additions in both files.
Description check ✅ Passed The description covers all required template sections (Summary, Changes, How to Test/Checklist) with concrete details about the changes and test verification steps, though the summary could be more concise.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/keypad-moonraker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sjordan0228
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 27, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sjordan0228 sjordan0228 merged commit bc5bf9a into dev Mar 27, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Mar 28, 2026
4 tasks
@sjordan0228 sjordan0228 deleted the feature/keypad-moonraker branch May 10, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant