fix: handling glob paths incorrectly on Windows #166
Merged
+23
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with glob paths being handled incorrectly on Windows caused by a breaking change in the glob package which no longer allows backslashes as path separators.
|
Nice, Up for merging :) |
|
Thanks so much! @kleinfreund |
josestbernard
pushed a commit
to josestbernard/vue-i18n-extract
that referenced
this pull request
Nov 3, 2022
…-windows fix: handling glob paths incorrectly on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with glob paths being handled incorrectly on Windows caused by a breaking change in the glob package which no longer allows backslashes as path separators.
Intends to fix #159.
I don’t use a Windows machine myself, so I’d appreciate someone using testing these changes.
Also, the approach for testing this change is rather naive as I’m merely simulating a Windows-style path by replacing the forward slashes in the paths used in the respective tests which is effectively the inverse of the implemented fix and so it doesn’t test a real scenario. I’m happy to hear about any suggestions improving this.
Furthermore, do you want me to include rebuilt distribution files in the PR branch or do you prefer to build separately before publishing a new version?