Make PsiStatements create a hard copy of the passed code block
#113
Conversation
|
|
||
| /** | ||
| * Returns the first child of this element. | ||
| */ | ||
| public val firstChild: PsiElement = children.first() | ||
| public val firstChild: PsiElement |
There was a problem hiding this comment.
Maybe it's firstStatement to avoid the confusion with the braces being also children?
There was a problem hiding this comment.
The first and last children may be formatting elements.
|
|
||
| /** | ||
| * Returns the last child of this element. | ||
| */ | ||
| public val lastChild: PsiElement = children.last() | ||
| public val lastChild: PsiElement |
There was a problem hiding this comment.
Same comment to the name and the type of the field. Is it a statement what we're getting here?
| public val firstChild: PsiElement = children.first() | ||
| public val firstChild: PsiElement | ||
| get() { | ||
| // Checking for `>2` because we are not interested in surrounding braces. |
There was a problem hiding this comment.
Strictly speaking, it is your particular use-cases, in which the access to the braces isn't needed. In other cases such access may be required.
Instead of overriding the firstChild and lastChild altogether, I would rather have another pair of properties which would serve your needs.
There was a problem hiding this comment.
In other cases such access may be required.
Then this type should not be used. Original PsiCodeBlock represents statements with braces.
These methods are not overridden because the class doesn't extend PsiElement. Otherwise, it'd be quite complex.
There was a problem hiding this comment.
So, the suggested property names may need revision. We do return children.first().nextSibling. It is NOT firstChild. It is something else.
| public val firstChild: PsiElement = children.first() | ||
| public val firstChild: PsiElement | ||
| get() { | ||
| // Checking for `>2` because we are not interested in surrounding braces. |
There was a problem hiding this comment.
So, the suggested property names may need revision. We do return children.first().nextSibling. It is NOT firstChild. It is something else.
There was a problem hiding this comment.
@yevhenii-nadtochii please feel free to re-request the review once the changes discussed vocally are implemented. Thanks!
This PR fixes implementation of
PsiStatementsmaking it more reliable.Changes are the following:
firstChildandlastChildproperties now throw with the error message when thePsiStatementsis empty.PsiStatements.