Skip to content
This repository was archived by the owner on May 14, 2020. It is now read-only.

Conversation

@gpasztor87
Copy link
Contributor

No description provided.

@spartantri
Copy link
Contributor

👍

@dune73 dune73 self-assigned this Oct 16, 2017
@dune73
Copy link
Contributor

dune73 commented Oct 16, 2017

Thank you, @gpasztor87. It's housekeeping PRs like yours that keep our project in a fresh state.

I have 2 remarks before I merge this.

  • I think the link to https://sourceforge.net/projects/mod-security/ should go to the reference manual.
  • The range requests reference should also link https://tools.ietf.org/html/rfc7233

And finally, did you check all the references everywhere or only a subselection?

@gpasztor87
Copy link
Contributor Author

@dune73 I changed what you suggested.
I checked all the references in the rules.

Cheers

@dune73
Copy link
Contributor

dune73 commented Oct 16, 2017

Thanks for the update.

The reference manual link used to go right to the right section, you are now linking to the manual generally without the #REQBODY_ERROR and the #MULTIPART_STRICT_ERROR anchor.

And the link to https://tools.ietf.org/html/rfc7233 is now in the wrong section. I think it has to be referenced on lines 312 and 356 and not on line 386 that speaks of character encoding.

Sorry to be such a bad sport ...

@gpasztor87
Copy link
Contributor Author

No problem, I fixed it.

@dune73
Copy link
Contributor

dune73 commented Oct 16, 2017

Perfect. Thank you for your contribution. Merging now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants