Skip to content
This repository was archived by the owner on May 14, 2020. It is now read-only.

Conversation

@zimmerle
Copy link
Contributor

Missing quote at the end of the rule 920200

@lifeforms
Copy link
Contributor

I have the feeling ModSec 3 parser has become more strict? ;)

@zimmerle
Copy link
Contributor Author

lol. Yes the v3 parser is more strict.

I was trying to load the rules on version 3 and I faced some issues. I did not tested on 2.x family; Regarding 2.x, there are two options: a more flexible parser or a silent error :)

I think it worth to fix it here, independent of the flexibility of the parser, what do you guys think?

@lifeforms
Copy link
Contributor

lifeforms commented Aug 26, 2016

@zimmerle We absolutely should fix these CRS bugs and I'm very glad that you tested it already! In the future, I definitely want more linting, which will probably be best to do with the modsec3 python bindings. This should also ensure that we won't create too long lines (Apache 2.2), work around parser buffering bug (early Apache 2.4), forget tags, maybe even validate regexps against some common bugs/evasions, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants