Skip to content
This repository was archived by the owner on May 14, 2020. It is now read-only.

Conversation

@annawinkler
Copy link
Contributor

Per issue #1060, add paranoia-level/1 tag to those rules.

@annawinkler annawinkler changed the title Add PL1 tag [1060] Add PL1 tag Oct 12, 2019
@csanders-git
Copy link
Contributor

I see no issue with this merge any thoughts @dune73

@airween
Copy link
Contributor

airween commented Oct 12, 2019

I see no issue with this merge any thoughts @dune73

See #1060 :)

@airween
Copy link
Contributor

airween commented Oct 12, 2019

Let me check this with parser before merge.

@csanders-git
Copy link
Contributor

Can we inline the parser into Travis?

@csanders-git
Copy link
Contributor

Also feel free to merge once you check

@airween
Copy link
Contributor

airween commented Oct 12, 2019

Can we inline the parser into Travis?

Yes, that's on my todo list - coming soon :)

@airween
Copy link
Contributor

airween commented Oct 12, 2019

@annawinkler thanks for your patch. I reviewed the modifications with the parser, but I'm afraid there are some missed tag - see this table. You can turn on the filter and can see only the rows with value 0 in column 'L'. (There couldn't be any row with value 0 in this column.)

Here are the rules:
912120
912130
912140
912150
912160
912161
912170

Those rules also activated at PL1, see the setter line.

If you're done, just check your modifications with the given script, which generates the new table. Don't forget to re-build the structure from the modified rules before (with command crs_read.py). Then you can check that everything is well. If you have any question, just let me know :).

@annawinkler
Copy link
Contributor Author

Thank you for checking this PR @airween! I'll add those rules and double-check per your comment.

@fgsch
Copy link
Contributor

fgsch commented Oct 20, 2019

Hi @annawinkler. Are you planning to update this soon~ish or should we consider merging it as is and tackle the remaining rules in a separate PR?

@airween
Copy link
Contributor

airween commented Oct 21, 2019

I think the separated PR could lead to misunderstanding in this case (if somebody review the commits few mounts later).

@annawinkler
Copy link
Contributor Author

Sorry for the delay friends! I'll work on this today.

@annawinkler
Copy link
Contributor Author

@fgsch and @airween I updated the rules and ran airween's script to verify the PL tag correct value in the generated csv file (generated from yaml from the rules). I do not see any 0 values, so I think all of the rules that should be tagged PL1 are. Could you please confirm and let me know? Thanks!

@airween airween merged commit a45ae41 into SpiderLabs:v3.3/dev Oct 21, 2019
@airween
Copy link
Contributor

airween commented Oct 21, 2019

Nice work @annawinkler, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants