-
Notifications
You must be signed in to change notification settings - Fork 732
[1060] Add PL1 tag #1594
[1060] Add PL1 tag #1594
Conversation
|
I see no issue with this merge any thoughts @dune73 |
|
Let me check this with parser before merge. |
|
Can we inline the parser into Travis? |
|
Also feel free to merge once you check |
Yes, that's on my todo list - coming soon :) |
|
@annawinkler thanks for your patch. I reviewed the modifications with the parser, but I'm afraid there are some missed Here are the rules: Those rules also activated at PL1, see the setter line. If you're done, just check your modifications with the given script, which generates the new table. Don't forget to re-build the structure from the modified rules before (with command |
|
Thank you for checking this PR @airween! I'll add those rules and double-check per your comment. |
|
Hi @annawinkler. Are you planning to update this soon~ish or should we consider merging it as is and tackle the remaining rules in a separate PR? |
|
I think the separated PR could lead to misunderstanding in this case (if somebody review the commits few mounts later). |
|
Sorry for the delay friends! I'll work on this today. |
f81e238 to
42b8f60
Compare
42b8f60 to
5354faa
Compare
|
Nice work @annawinkler, thank you! |
Per issue #1060, add
paranoia-level/1tag to those rules.