Skip to content
This repository was archived by the owner on May 14, 2020. It is now read-only.

Add NGINX Docker and Travis Testing support. #1113

Closed
wants to merge 4 commits into from
Closed

Add NGINX Docker and Travis Testing support. #1113

wants to merge 4 commits into from

Conversation

@csanders-git
Copy link
Contributor

@csanders-git csanders-git commented Jun 4, 2018

No description provided.

@csanders-git csanders-git changed the title inital Docker Nginx support Add NGINX Docker and Travis Testing support. Jun 4, 2018
@csanders-git
Copy link
Contributor Author

csanders-git commented Jun 28, 2018

Testing for FTW is waiting on https://github.com/SpiderLabs/ModSecurity/tree/d810de9166794be2bee972fffb0e09cb0b8d6ec5

Any idea when this will be merged into master @victorhora or should i make our docker image read from a diff branch?

@dune73 dune73 mentioned this pull request Dec 3, 2018
Closed
@lifeforms lifeforms mentioned this pull request Dec 3, 2018
Closed
@franbuehler franbuehler self-assigned this Dec 3, 2018
@csanders-git csanders-git mentioned this pull request Dec 12, 2018
Open
@dune73
Copy link
Contributor

dune73 commented Dec 14, 2018 •
edited
Loading

What are we doing with this PR? It's outdated / conflicting and should probably started anew. Also in light of @franbuehler's addition to the official docker container slowly approaching the pipeline.

@dune73 dune73 mentioned this pull request Dec 26, 2018
Closed
@lifeforms lifeforms added this to the CRS v3.2.0 milestone Dec 29, 2018
@dune73 dune73 mentioned this pull request Mar 4, 2019
Closed
@dune73
Copy link
Contributor

dune73 commented Mar 4, 2019

@csanders-git has picked this up again. It's being discussed in crscontainers on OWASP slack. He has a draft new base container. There for 1 week for reviews now, then @franbuehler and @danehrlich1 will pick it up from there.
@csanders-git will rebase this PR afterwards.

@dune73 dune73 mentioned this pull request Apr 1, 2019
Closed
@ghost
Copy link

ghost commented May 15, 2019

Was this ever rebased?

@csanders-git
Copy link
Contributor Author

csanders-git commented May 15, 2019

@danehrlich1 no going to be completely replaced with the new docker image

@csanders-git
Copy link
Contributor Author

csanders-git commented May 29, 2019

Closing as an updated version has been pushed upstream

@CRS-migration-bot CRS-migration-bot mentioned this pull request May 13, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@csanders-git csanders-git

@franbuehler franbuehler

Labels

None yet

Projects

None yet

Milestone

CRS v3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@csanders-git @dune73 @lifeforms @franbuehler