This repository was archived by the owner on May 14, 2020. It is now read-only.
bring back PHP closing tag '?>' detection #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Would you mind adding a note to 933100 about the existence of 933101 in PL3? Otherwise, I am not sure this is a strict sibling as 933100 deals with opening tags and a closing tag is related but could also be entered as 933180. |
Contributor
|
Thanks for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #766.
We removed
?>detection in 3.0.1 because of FP reports, which couldn't be resolved in a reasonable way. Now, it's back as a separate rule in paranoia level 3.