fix: partial matches #187
Open
fix: partial matches #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #187 +/- ##
===========================================
- Coverage 92.62% 92.47% -0.15%
===========================================
Files 66 66
Lines 2780 2686 -94
Branches 733 635 -98
===========================================
- Hits 2575 2484 -91
- Misses 200 201 +1
+ Partials 5 1 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Hey @nklomp just want to check if the direction of this PR looks ok to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I meant to create a small fix that we identified when requesting two credentials and only one being present (it would match none).
While fixing this I discovered the selectFrom would something return
INFO, even though the required credentials were not present. So I rewrote quite a big chunk of matching logic. It doesn't touch the actual matching based on input descriptors, but it heavily modifies the submission requirement matching and the sub-result combining.The
matchesstructure is much richer now, allow for much more advanced credential selection in wallets. I know with DCQL we probably don't want to make too big changes to this library anymore, but the current results were sometimes not fully expressive with submission requirements (and especially nested submission requirements).