Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name property to field definition #123

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

mistermoe
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    adds name property to field definition in pd v2 json schema

  • What is the current behavior? (You can also link to an open issue here)
    using evaluatePresentation method fails when presentation definition includes a field object with the name property in it

  • What is the new behavior (if this is a feature change)?

  • Other information:

Reference from the PEX V2 spec

image

@mistermoe
Copy link
Contributor Author

Related: Sphereon-Opensource/pex-openapi#28

Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@codecov-commenter
Copy link

Codecov Report

Merging #123 (e35b355) into develop (32e30c9) will decrease coverage by 0.21%.
The diff coverage is n/a.

❗ Current head e35b355 differs from pull request most recent head 6044810. Consider uploading reports for the commit 6044810 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
- Coverage    95.91%   95.70%   -0.21%     
===========================================
  Files           63       63              
  Lines         2203     2213      +10     
  Branches       411      473      +62     
===========================================
+ Hits          2113     2118       +5     
- Misses          90       92       +2     
- Partials         0        3       +3     
Flag Coverage Δ
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nklomp nklomp merged commit 4828ce8 into Sphereon-Opensource:develop Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants