Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/SSISDK-5_credential_offer_uri #180

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

sanderPostma
Copy link
Contributor

No description provided.

@sanderPostma sanderPostma marked this pull request as ready for review February 7, 2025 17:01
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 76.98413% with 29 lines in your changes missing coverage. Please review.

Project coverage is 50.03%. Comparing base (1552b5f) to head (e1c8bc2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/client/lib/CredentialOfferClientV1_0_13.ts 11.11% 16 Missing ⚠️
packages/oid4vci-common/lib/functions/Encoding.ts 50.00% 6 Missing ⚠️
packages/issuer-rest/lib/oid4vci-api-functions.ts 90.62% 3 Missing ⚠️
packages/client/lib/CredentialOfferClient.ts 81.81% 2 Missing ⚠️
...ackages/client/lib/CredentialOfferClientV1_0_11.ts 0.00% 1 Missing ⚠️
...kages/issuer/lib/functions/CredentialOfferUtils.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #180      +/-   ##
===========================================
+ Coverage    48.88%   50.03%   +1.14%     
===========================================
  Files           75       76       +1     
  Lines         5357     5424      +67     
  Branches      1817     1880      +63     
===========================================
+ Hits          2619     2714      +95     
+ Misses        2735     2708      -27     
+ Partials         3        2       -1     
Flag Coverage Δ
unittest 50.03% <76.98%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanderPostma
Copy link
Contributor Author

But now after adding additional coverage it is not redoing the CodeCov report...

Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have improvements in another branch, so OK to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants