Skip to content

Commit

Permalink
chore: fixed CredentialOfferClientV1_0_13.ts
Browse files Browse the repository at this point in the history
  • Loading branch information
sanderPostma committed Feb 8, 2025
1 parent 6be8f28 commit c91aad8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/client/lib/CredentialOfferClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ export class CredentialOfferClient {
} else {
if (uri.includes('credential_offer_uri')) {
const uriObj = getURIComponentsAsArray(uri) as unknown as Record<string, string> // FIXME
const credentialOfferUri = uriObj['credential_offer_uri']
const decodedUri = decodeURIComponent(credentialOfferUri);
const credentialOfferUri = decodeURIComponent(uriObj['credential_offer_uri'])
const decodedUri = decodeURIComponent(credentialOfferUri); // It is double URI encoded
const response = await fetch(decodedUri)
if (!(response && response.status >= 200 && response.status < 400)) {
return Promise.reject(`the credential offer URI endpoint call was not successful. http code ${response.status} - reason ${response.statusText}`)

Check warning on line 53 in packages/client/lib/CredentialOfferClient.ts

View check run for this annotation

Codecov / codecov/patch

packages/client/lib/CredentialOfferClient.ts#L53

Added line #L53 was not covered by tests
Expand Down
2 changes: 1 addition & 1 deletion packages/client/lib/CredentialOfferClientV1_0_13.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class CredentialOfferClientV1_0_13 {
let credentialOffer: CredentialOffer
if (uri.includes('credential_offer_uri')) { // FIXME deduplicate
const uriObj = getURIComponentsAsArray(uri) as unknown as Record<string, string> // FIXME
const credentialOfferUri = uriObj['credential_offer_uri']
const credentialOfferUri = decodeURIComponent(uriObj['credential_offer_uri']) // It is double URI encoded
const decodedUri = decodeURIComponent(credentialOfferUri);
const response = await fetch(decodedUri)

Check warning on line 33 in packages/client/lib/CredentialOfferClientV1_0_13.ts

View check run for this annotation

Codecov / codecov/patch

packages/client/lib/CredentialOfferClientV1_0_13.ts#L30-L33

Added lines #L30 - L33 were not covered by tests
if (!(response && response.status >= 200 && response.status < 400)) {
Expand Down

0 comments on commit c91aad8

Please sign in to comment.