Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3 Fixed - Modal Form Created and linked to "Find a Partner" Button #41

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

Nikitha2309
Copy link
Contributor

@Nikitha2309 Nikitha2309 commented Mar 20, 2021

#3 - A Modal Form has been created and linked to the "Find a Project Partner" Button".

Description

  • All frontend regarding the issue is implemented.
  • No new dependency required to be installed
  • Changed Files -
    * LesKollab\assets\css\styles.css
    * LesKollab\index.php

Type of Change:

Delete irrelevant options.

  • Code
  • User Interface

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)
  • Documentation about the "Find a Project Partner" Button is to be updated.
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I have run the project locally after implementing the feature and there is no glitch found.
Here is the video of the output of the test run.

LesKollab.-.Google.Chrome.2021-03-21.03-53-23.mp4

@Nikitha2309
Copy link
Contributor Author

Nikitha2309 commented Mar 20, 2021

I believe slow improvements to the project help improving the project smoothly without more conflicts. Resolving issues step by step helps us to focus more on each step and thereby results in a good website.

Also to fix #3 , I assume only implementing a modal form with required fields as inputs and connecting this to the "Find a Project Partner" button are the tasks that need to be fulfilled.

I have fixed the issue and tested it. Hence I request @rupeshmohanty to review and merge the PR and close it.

@Nikitha2309 Nikitha2309 changed the title Issue#3 Fixed - Modal Form Created and linked to "Find a Partner" Button Issue #3 Fixed - Modal Form Created and linked to "Find a Partner" Button Mar 20, 2021
@Nikitha2309
Copy link
Contributor Author

Nikitha2309 commented Mar 22, 2021

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

@rupeshmohanty
Copy link
Contributor

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

What happens once you click on find a partner?

@Nikitha2309
Copy link
Contributor Author

Nikitha2309 commented Mar 22, 2021

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

What happens once you click on find a partner?

I will get a popup modal form and required fields are taken as input, as shown in the video . I will be glad to help with any parts if not understood, thank you

@rupeshmohanty
Copy link
Contributor

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

What happens once you click on find a partner?

I will get a popup modal form and required fields are taken as input, as shown in the video

Okay let the mentors check the code, then I will merge the code.

@Nikitha2309
Copy link
Contributor Author

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

What happens once you click on find a partner?

I will get a popup modal form and required fields are taken as input, as shown in the video

Okay let the mentors check the code, then I will merge the code.

Thank You, I have already asked @anika-001 to review my code, and I got a reply in the discord channel that everything is fine. You can check there once :)

Copy link
Collaborator

@sakshi300699 sakshi300699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@Nikitha2309
Copy link
Contributor Author

Thanks for the support guys 😀

@rupeshmohanty rupeshmohanty merged commit 9b735f9 into Spectrum-CETB:main Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants