-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #3 Fixed - Modal Form Created and linked to "Find a Partner" Button #41
Conversation
I believe slow improvements to the project help improving the project smoothly without more conflicts. Resolving issues step by step helps us to focus more on each step and thereby results in a good website. Also to fix #3 , I assume only implementing a modal form with required fields as inputs and connecting this to the "Find a Project Partner" button are the tasks that need to be fulfilled. I have fixed the issue and tested it. Hence I request @rupeshmohanty to review and merge the PR and close it. |
@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR? |
What happens once you click on find a partner? |
I will get a popup modal form and required fields are taken as input, as shown in the video . I will be glad to help with any parts if not understood, thank you |
Okay let the mentors check the code, then I will merge the code. |
Thank You, I have already asked @anika-001 to review my code, and I got a reply in the discord channel that everything is fine. You can check there once :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great!
Thanks for the support guys 😀 |
#3 - A Modal Form has been created and linked to the "Find a Project Partner" Button".
Description
* LesKollab\assets\css\styles.css
* LesKollab\index.php
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
I have run the project locally after implementing the feature and there is no glitch found.
Here is the video of the output of the test run.
LesKollab.-.Google.Chrome.2021-03-21.03-53-23.mp4