Guard hot-path diagnostics

apps/desktop/src/lib/trpc/routers/gastown/agents.ts

@@ -46,17 +46,8 @@ export const createGastownAgentsRouter = (
 			.query(async ({ input }) => {
 				const resolved = resolveTownPathImpl(input?.townPath);
 				const opts = await shellOptions();
-				console.log("[gastown-agents.list] input", {
-					input,
-					resolvedTownRoot: resolved,
-					env_keys: Object.keys(opts.env).filter(
-						(k) => k.includes("PATH") || k.includes("GT") || k.includes("HOME"),
-					),
-				});
 				try {
-					const result = await listAgentsImpl({ townRoot: resolved }, opts);
-					console.log("[gastown-agents.list] ok", { count: result.length });
-					return result;
+					return await listAgentsImpl({ townRoot: resolved }, opts);
 				} catch (e) {
 					const err = e as Error;
 					console.error("[gastown-agents.list] FAIL", {

apps/desktop/src/renderer/components/Gastown/AgentCVPanel/AgentCVPanel.test.tsx

@@ -1,4 +1,4 @@
-import { describe, expect, it, mock } from "bun:test";
+import { describe, expect, it, mock, spyOn } from "bun:test";
 import type { AgentSummary } from "@spectralset/gastown-cli-client";
 import { renderToStaticMarkup } from "react-dom/server";
 
@@ -44,6 +44,7 @@ mock.module("@spectralset/ui/sonner", () => ({
 }));
 
 mock.module("@tanstack/react-router", () => ({
+	useNavigate: () => () => {},
 	useParams: () => ({}),
 }));
 
@@ -92,6 +93,18 @@ describe("AgentCVPanel", () => {
 		expect(html).toContain("No agents.");
 	});
 
+	it("does not log diagnostics during render", () => {
+		const logSpy = spyOn(console, "log").mockImplementation(() => {});
+		listState = { data: [], isLoading: false, error: null };
+
+		try {
+			renderToStaticMarkup(<AgentCVPanel />);
+			expect(logSpy).not.toHaveBeenCalled();
+		} finally {
+			logSpy.mockRestore();
+		}
+	});
+
 	it("renders loading state", () => {
 		listState = { data: undefined, isLoading: true, error: null };
 		const html = renderToStaticMarkup(<AgentCVPanel />);

apps/desktop/src/renderer/components/Gastown/AgentCVPanel/AgentCVPanel.tsx

@@ -3,8 +3,8 @@ import type {
 	AgentState,
 	AgentSummary,
 } from "@spectralset/gastown-cli-client";
-import { useNavigate } from "@tanstack/react-router";
 import { cn } from "@spectralset/ui/utils";
+import { useNavigate } from "@tanstack/react-router";
 import { useMemo, useState } from "react";
 import { HiOutlineUserGroup } from "react-icons/hi2";
 import { useGastownTownPath } from "renderer/hooks/useGastownTownPath";
@@ -112,21 +112,6 @@ export function AgentCVPanel() {
 	const agents = listQuery.data ?? [];
 	const groups = useMemo(() => groupAgents(agents), [agents]);
 
-	console.log("[AgentCVPanel] query", {
-		townPathOverride,
-		probeTownRoot: probeQuery.data?.townRoot,
-		probeStatus: probeQuery.status,
-		resolvedTownPath: townPath,
-		listStatus: listQuery.status,
-		listError: listQuery.error
-			? {
-					message: listQuery.error.message,
-					data: (listQuery.error as unknown as { data?: unknown }).data,
-				}
-			: null,
-		agentsCount: agents.length,
-	});
-
 	return (
 		<div className="flex h-full flex-col">
 			<header className="flex items-center gap-3 border-b border-border/60 px-4 py-3">

apps/desktop/src/renderer/lib/trpc-client.ts

@@ -6,20 +6,12 @@ import { ipcLink } from "trpc-electron/renderer";
 import { electronTrpc } from "./electron-trpc";
 import { sessionIdLink } from "./session-id-link";
 
-// ss-8ui DIAG: log every outgoing tRPC call + result to find where gastown.agents.list is dropped
-const loggingLink: TRPCLink<AppRouter> =
+const errorLoggingLink: TRPCLink<AppRouter> =
 	() =>
 	({ op, next }) =>
 		observable((observer) => {
-			console.log("[trpc-outgoing]", {
-				path: op.path,
-				type: op.type,
-				input: op.input,
-				id: op.id,
-			});
 			const sub = next(op).subscribe({
 				next: (v) => {
-					console.log("[trpc-incoming]", { path: op.path, id: op.id });
 					observer.next(v);
 				},
 				error: (err) => {
@@ -33,7 +25,6 @@ const loggingLink: TRPCLink<AppRouter> =
 					observer.error(err);
 				},
 				complete: () => {
-					console.log("[trpc-complete]", { path: op.path, id: op.id });
 					observer.complete();
 				},
 			});
@@ -42,10 +33,18 @@ const loggingLink: TRPCLink<AppRouter> =
 
 /** Electron tRPC React client for React hooks (used by ElectronTRPCProvider). */
 export const electronReactClient = electronTrpc.createClient({
-	links: [loggingLink, sessionIdLink(), ipcLink({ transformer: superjson })],
+	links: [
+		errorLoggingLink,
+		sessionIdLink(),
+		ipcLink({ transformer: superjson }),
+	],
 });
 
 /** Electron tRPC proxy client for imperative calls from stores/utilities. */
 export const electronTrpcClient = createTRPCProxyClient<AppRouter>({
-	links: [loggingLink, sessionIdLink(), ipcLink({ transformer: superjson })],
+	links: [
+		errorLoggingLink,
+		sessionIdLink(),
+		ipcLink({ transformer: superjson }),
+	],
 });