Add project_scope_tag_id scope-to-tag functionality to some api otu queries
#4232
Conversation
I'm not entirely sure this is what was intended. (The previous version was more or less random, so I'm also not sure how much this is being relied upon.)
|
In progress - there may still be some additions. |
|
|
||
| if project_scope_tag_id.present? | ||
| q = q.joins(:tags) | ||
| .where("tags.tag_object_type = 'Otu' AND tags.keyword_id = #{project_scope_tag_id}") |
There was a problem hiding this comment.
I don't need tags.tag_object_type = 'Otu' here, it's covered by joins(:tags)
| descendants = descendants | ||
| .joins(:otus) | ||
| .joins("JOIN tags ON tags.tag_object_type = 'Otu' AND tags.tag_object_id = otus.id") | ||
| .where("tags.keyword_id = #{project_scope_tag_id}") |
There was a problem hiding this comment.
where(:tags: {keyword_id: project_scope_tag_id}
| # The project scope tag has the property that any ancestor of a tagged | ||
| # otu is also tagged, so this is legit. | ||
| descendants = descendants | ||
| .joins(:otus) |
| @@ -101,9 +120,12 @@ def otu_descendants_and_synonyms( | |||
| end | |||
| data[:leaf_node] = data[:descendants].empty? | |||
| else | |||
| data[:leaf_node] = descendants.where.not(id: similar_otus).none? | |||
There was a problem hiding this comment.
see about adding .unscope(:order) on call using descendant etc. it can save a lot of time`
| @@ -26,6 +26,10 @@ class Autocomplete < Query::Autocomplete | |||
| # if 'true' then only #name = query_string results are returned (no fuzzy matching) | |||
| attr_accessor :exact | |||
|
|
|||
| # @return Integer, nil | |||
| # Only return otus tagged with this tag id | |||
| attr_accessor :project_scope_tag_id | |||
There was a problem hiding this comment.
I'm worried about the scope in various other places, there are various other filter results that need this scoping that are used. Before we get too far I'd like to enumerate where else we'd need this tag param to ensure consistency across the site. Remember too that for basic OTUs this works fine, but as as soon as we add all the filters/search that others want to use this will be quite difficult to maintain without a lot of thought.
| descendants = otu.taxon_name.descendants | ||
| .where(parent: otu.taxon_name).that_is_valid | ||
|
|
||
| if project_scope_tag_id |
There was a problem hiding this comment.
@kleintom Internal to catalog, rather than a tag Id. I think we should try to use an Otu scope as the join, that would let us pre-define any set of OTUs. The concern would be performance, but let's experiment with it.
External to Catalog their might be a configure wrapper, that handles creating the OTU scopes.
So in the tag case the otu_bounding_scope= Otu.joins(:tags).where(tags: {keyword_id: 123})
No description provided.