Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support build efsw in bazel toolchain #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashione
Copy link

@ashione ashione commented Oct 22, 2022

Create a bazel workspace meta data and make users can acccess in bazel repo.
More details can get from website Bazel intro https://bazel.build/about/intro.

My laptop version passes all of building, and env :

  • OS : both centos7 and macos 11.5.1
  • bazel version : 4.2.1
  • gcc 9.2.1

@ashione ashione mentioned this pull request Oct 22, 2022
@ashione
Copy link
Author

ashione commented Oct 22, 2022

BTW, anyone can build it in windows might help us to verify the last OS since I can not access any windows PC right here.

@SpartanJ
Copy link
Owner

Thank you very much for your contribution! I left some minor comments. But, I'm not sure if adding this to the main repository makes sense. I cannot maintain every single build system people need to use with efsw, and bazel is a very specific and complex build system, primarily used in AI environments. I'll think about it. I also don't have the Windows environment ready to test with bazel.

@ashione
Copy link
Author

ashione commented Oct 22, 2022

Thank you very much for your contribution! I left some minor comments. But, I'm not sure if adding this to the main repository makes sense. I cannot maintain every single build system people need to use with efsw, and bazel is a very specific and complex build system, primarily used in AI environments. I'll think about it. I also don't have the Windows environment ready to test with bazel.

Never mind. I just find this repo can me watch file or directory changes that's really helpful. Bazel is easy to use and it's pleasure to maintain this toolchain in this repo if you make the decision to merge this into mainstream.

More and more repo support mutilple build tools. Absl is a basic library, for example, https://github.com/abseil/abseil-cpp, has both cmake and bazel building ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants