Added semaphore support for Linux platform #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristianDragu
commented
May 2, 2019
CristianDragu
commented
- most of the implementation added
CristianDragu
force-pushed
the
cdragu/semaphore_mac_integration
branch
from
718b61b to
b2edc44
Compare
lucteo
reviewed
May 10, 2019
| [ct] if platformName == "Linux" | ||
| datatype NativeThreadHandle = ULong | ||
| else | ||
| datatype NativeThreadHandle = Byte Ptr // Opaque type |
There was a problem hiding this comment.
[minor, not introduced in this patch]
Change to UntypedPtr
| import std.ptr | ||
|
|
||
| datatype NativeThreadHandle = Byte Ptr // Opaque type | ||
| [ct] if platformName == "Linux" | ||
| datatype NativeThreadHandle = ULong |
There was a problem hiding this comment.
I think you also need to add the >> operator for the new type (if I remember correctly it will not be autogenerated, so you can't print a NativeThreadHandle)
|
|
||
| using InvalidThreadHandle = NativeThreadHandle() |
There was a problem hiding this comment.
you don't define InvalidThreadHandle for Linux
| [native("sysconf")] fun sysconf(name: Int): Long | ||
| [ct] if platformName == "Darwin" | ||
| using _SC_NPROCESSORS_ONLN = 58 | ||
| else |
There was a problem hiding this comment.
I would also test for Linux on the else branch. Just to be sure
| import config | ||
|
|
||
| datatype TimeSpecT |
There was a problem hiding this comment.
This should not be public to this file
| [ct] if platformName == "Darwin" | ||
| var res = _Impl.semaphore_create(_Impl.mach_task_self(), _handle, _Impl.SYNC_POLICY_FIFO, Int(startValue)) | ||
| else | ||
| var res = _Impl.sem_init(_handle, Int(0), UInt(startValue)) |
There was a problem hiding this comment.
Didn't you implement this in a Posix header?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.